Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rev minikube version and disable ubuntu build. #283

Merged
merged 1 commit into from
May 12, 2019
Merged

Rev minikube version and disable ubuntu build. #283

merged 1 commit into from
May 12, 2019

Conversation

brendandburns
Copy link
Contributor

See if this fixes our CI...

@xinyanmsft @qmfrederik

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 4, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 4, 2019
@brendandburns brendandburns requested review from itowlson and removed request for krabhishek8260 May 4, 2019 00:10
@brendandburns
Rev minikube version.
1693483 
Also disable ubuntu build since it's broken.
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 4, 2019
@brendandburns brendandburns changed the title Rev minikube version. Rev minikube version and disable ubuntu build. May 7, 2019
@xinyanmsft
Copy link
Contributor

I am still getting this error for Ubuntu build. Can you guys complete this PR to fix that issue? thanks!

  • Sorry that minikube crashed. If this was unexpected, we would love to hear from you:

@brendandburns
Copy link
Contributor Author

@xinyanmsft I'd like to merge this to fix our tests by disabling the build, and then I'll send a separate PR to re-enable/fix Ubuntu.

Any chance you can LGTM and then we can work from there...

@xinyanmsft
Copy link
Contributor

LGTM. Thanks!

@brendandburns brendandburns merged commit e42916a into kubernetes-client:master May 12, 2019
@tomkerkhove tomkerkhove mentioned this pull request May 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itowlson itowlson Awaiting requested review from itowlson

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brendandburns @k8s-ci-robot @xinyanmsft