Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix DisposeWatch test fickle #365

Merged
merged 1 commit into from
Mar 9, 2020
Merged

fix DisposeWatch test fickle #365

merged 1 commit into from
Mar 9, 2020

Conversation

tg123
Copy link
Member

@tg123 tg123 commented Mar 9, 2020 •
edited
Loading

seems a regression in upgrading t Nito.AsyncEx 5.0

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 9, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 9, 2020
@tg123
Copy link
Member Author

tg123 commented Mar 9, 2020

There are many other await Task.WhenAny(eventsReceived.WaitAsync(), Task.Delay(TestTimeout));

still may cause test fail but this case fail frequently,
I am file a bug to AsyncEx

@tg123 tg123 mentioned this pull request Mar 9, 2020
Open
@brendandburns
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, tg123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0468a66 into kubernetes-client:master Mar 9, 2020
@tg123 tg123 deleted the fix_async_test_fail branch March 10, 2020 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@krabhishek8260 krabhishek8260 Awaiting requested review from krabhishek8260

Assignees

@brendandburns brendandburns

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tg123 @brendandburns @k8s-ci-robot