Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore : csr approval example using json patch net package #816

Merged
merged 4 commits into from
Apr 1, 2022
Merged

chore : csr approval example using json patch net package #816

merged 4 commits into from
Apr 1, 2022

Conversation

kibernetik542
Copy link
Contributor

In this example using json-patch-net package and generating default x509 certificate we can approve k8s csr certificate

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 1, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 1, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @kibernetik542!

It looks like this is your first PR to kubernetes-client/csharp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/csharp has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 1, 2022
@kibernetik542 kibernetik542 mentioned this pull request Apr 1, 2022
Closed
@kibernetik542
Copy link
Contributor Author

/assign @krabhishek8260

@brendandburns
Copy link
Contributor

This looks good to me, but we need you to sign the CLA.

Thanks!

@brendandburns brendandburns removed the request for review from krabhishek8260 April 1, 2022 16:59
@kibernetik542
Copy link
Contributor Author

This looks good to me, but we need you to sign the CLA.

Thanks!

Thanks for feedback, I made PR for CLA waiting for approval.

tg123
tg123 reviewed Apr 1, 2022
View reviewed changes
examples/csrApproval/csrApproval.csproj Show resolved Hide resolved
examples/csrApproval/Program.cs Outdated
using k8s;
using k8s.Models;

namespace csrApproval
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional

https://docs.microsoft.com/en-us/dotnet/csharp/fundamentals/program-structure/top-level-statements

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added using top level statement

@jarias-lfx
Copy link

/easycla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 1, 2022
tg123
tg123 reviewed Apr 1, 2022
View reviewed changes
examples/csrApproval/csrApproval.csproj Outdated

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net6.0</TargetFramework>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

target can be removed as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kibernetik542
To complete the pull request process, please ask for approval from krabhishek8260 after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tg123
Copy link
Member

tg123 commented Apr 1, 2022

Thanks
/LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2022
@tg123 tg123 merged commit 92ccac4 into kubernetes-client:master Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tg123 tg123 tg123 left review comments

@brendandburns brendandburns Awaiting requested review from brendandburns

Assignees

@tg123 tg123

@krabhishek8260 krabhishek8260

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kibernetik542 @k8s-ci-robot @brendandburns @jarias-lfx @tg123 @krabhishek8260