-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
missing support for custom object status/scale api #71
Comments
This isnt intentional. We should fix, would love a pr... |
I'd love to but I can't find any documentation how this file is generated. |
@mbohlool as you added the file originally, can you provide some guidance on how to best update it? |
You just need to edit that JSON Swagger file to have the new object, then everything "just works" when you regenerate... See the code here: gen/openapi/preprocess_spec.py Line 33 in 7d7ec1c
gen/openapi/preprocess_spec.py Line 105 in 7d7ec1c
|
yeah sure, but do you manually write that swagger file? It looks generated. |
This is the file: https://github.com/kubernetes-client/gen/blob/master/openapi/custom_objects_spec.json It is not auto-generated. The code Brendan referenced is where this spec get merged with the main spec (that one is generated). You can edit that file and add /scale and /status endpoints. |
yes thanks, I have already created a PR with the additions |
* improve error message on failed spec download * add scale and status api of custom objects Closes gh-71
since kubernetes 1.11 the custom object status/scale api is in beta:
https://kubernetes.io/docs/tasks/access-kubernetes-api/custom-resources/custom-resource-definitions/#status-subresource
But the generator does not support it as it is missing in
openapi/custom_objects_spec.json
If this is not intentional due to the beta status of the api it would be very helpful to have this added so clients can generate code for it.
The text was updated successfully, but these errors were encountered: