Feature: Support namespace-scoped informer #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
cncf-cla: yes
yue9944882
force-pushed
the
feat/support-namespaced-informer
branch
2 times, most recently
from
1b25c52 to
975a536
Compare
...test/java/io/kubernetes/client/spring/extended/controller/KubernetesInformerCreatorTest.java
Outdated
Show resolved
Hide resolved
util/src/main/java/io/kubernetes/client/informer/SharedInformerFactory.java
Outdated
Show resolved
Hide resolved
|
two really minor nits. We should set up an auto-formatter to organize imports so that we don't have to worry about this. otherwise LGTM |
yue9944882
force-pushed
the
feat/support-namespaced-informer
branch
2 times, most recently
from
595f3e1 to
17ddba6
Compare
util/src/test/java/io/kubernetes/client/informer/SharedInformerFactoryTest.java
Outdated
Show resolved
Hide resolved
|
Still seeing some wildcard imports. (sorry to be so nit-picky, but I want to keep us to a code style) we should really figure out how to block them in the validation, but it seems like spotless doesn't support this out of the box. |
yue9944882
force-pushed
the
feat/support-namespaced-informer
branch
2 times, most recently
from
ca96ed4 to
f683d85
Compare
yue9944882
force-pushed
the
feat/support-namespaced-informer
branch
from
f683d85 to
508512c
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, yue9944882 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.