Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When watch can't parse an object, try to parse it to a Status. #165

Merged
merged 1 commit into from
Jan 12, 2018
Merged

When watch can't parse an object, try to parse it to a Status. #165

merged 1 commit into from
Jan 12, 2018

Conversation

brendandburns
Copy link
Contributor

Fixes #164

@bhabermas
@jberhard
@mbohlool

@mbohlool
Copy link
Contributor

mbohlool commented Jan 12, 2018 •
edited
Loading

Catching exception works for now but it would be nice if we had a way to deserialize metadata first to see what is the actual object and then deserialize it in the right object. That would be much cleaner than trying to deserialize it and count on exception. This, however, can be done in another PR.

@mbohlool
Copy link
Contributor

/lgtm

@mbohlool mbohlool merged commit f32b284 into kubernetes-client:master Jan 12, 2018
@brendandburns
Copy link
Contributor Author

brendandburns commented Jan 12, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brendandburns @mbohlool @brendanburns