-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return a default APIClient if we run into an exception #1963
Return a default APIClient if we run into an exception #1963
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
4323090
to
471c84e
Compare
/check-cla |
I signed it |
/check-cla |
/assign @yue9944882 |
...kubernetes/client/spring/extended/controller/config/KubernetesInformerAutoConfiguration.java
Show resolved
Hide resolved
@@ -25,10 +28,32 @@ | |||
@ConditionalOnKubernetesInformerEnabled | |||
public class KubernetesInformerAutoConfiguration { | |||
|
|||
private static final Log LOG = LogFactory.getLog(KubernetesInformerAutoConfiguration.class); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: conventionally we use slf4j as the logging interface
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plz run mvn spotless:apply
to fix the format error
f80a767
to
0677a1a
Compare
@yue9944882 @brendandburns sorry for the delay in getting back to this. I actually think it might be simpler if we just try and create the ApiClient and if that fails we fall back to creating one that points to localhost. Let me know what you think. |
0677a1a
to
ad0e88a
Compare
@yue9944882 I believe I fixed the formatting issues, sorry about that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
@ryanjbaxter thanks a bunch!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ryanjbaxter, yue9944882 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…t-master Cherry Pick #1963 To Master
…t-13.0.x Cherry Pick #1963 To 13.0
Fixes #1946