Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 'adopt' --> 'temurin' #1980

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Nov 13, 2021

https://github.com/actions/setup-java/blob/main/README.md

NOTE: Adopt OpenJDK got moved to Eclipse Temurin and won't be 
updated anymore. It is highly recommended to migrate workflows 
from adopt to temurin to keep receiving software and security updates.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 13, 2021
@yue9944882
Copy link
Member

Available versions: 17.0.1+12, 17.0.0+35, 16.0.2+7, 11.0.13+8, 11.0.12+7, 8.0.312+7, 8.0.302+8

thanks @sullis, i think we need to remove JDK9 and the other unsupported versions from this list to switch to Temurin

@brendandburns
Copy link
Contributor

I'd suggest we remove both JDK9, JDK10 and JDK16 and we add JDK17

We should track the LTS JDKs + whatever the current development version is (will be JDK18 but it's not out yet)

@brendandburns
Copy link
Contributor

I just sent #1999 to update our matrix.

@brendandburns
Copy link
Contributor

@sullis if you rebase this I think it can merge.

Signed-off-by: sullis <github@seansullivan.com>
@sullis
Copy link
Contributor Author

sullis commented Nov 23, 2021

@sullis if you rebase this I think it can merge.

Rebased.

Copy link
Member

@yue9944882 yue9944882 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 24, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sullis, yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2021
@k8s-ci-robot k8s-ci-robot merged commit e8b4d60 into kubernetes-client:master Nov 24, 2021
@sullis sullis deleted the temurin-jdk branch December 19, 2021 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants