-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows to our build matrix. #2000
Add Windows to our build matrix. #2000
Conversation
c0aec5b
to
a8b4ba5
Compare
a8b4ba5
to
5feb527
Compare
/hold This is going to take more work :( |
5feb527
to
4ed746c
Compare
4ed746c
to
bad85c5
Compare
252e940
to
be50feb
Compare
021b471
to
c98f17e
Compare
c98f17e
to
38c553a
Compare
ebb4034
to
cadf986
Compare
/hold remove @yue9944882 this is ready for review. I will add macos in a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brendandburns this is awesome!!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, yue9944882 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.