Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-action: Upload snapshot as post-commit job #2040

Merged

Conversation

yue9944882
Copy link
Member

@yue9944882 yue9944882 commented Dec 22, 2021

@brendandburns i added my jira account credentials and gpg keys in the repo secrets to push snapshots. github claims that these secrets are perfectly protected 🤞

if this works well, we can move the maven release job as another job triggered by simple git tags. so we don't need to deal with the fiddly release process manually anymore!

Signed-off-by: yue9944882 <291271447@qq.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 22, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 22, 2021
@yue9944882 yue9944882 mentioned this pull request Dec 22, 2021
@brendandburns
Copy link
Contributor

Thanks for doing this. Is there an example of where these snapshots end-up? e.g. what is the version?

@yue9944882
Copy link
Member Author

yue9944882 commented Dec 23, 2021

@brendandburns they're pushed to sonatype oss snapshot repository, so developers can get quick access to the master branch package by adding the following repository to their pom.xml:

  <repositories>
    <repository>
      <id>oss.sonatype.org-snapshot</id>
      <url>http://oss.sonatype.org/content/repositories/snapshots</url>
      <releases>
        <enabled>false</enabled>
      </releases>
      <snapshots>
        <enabled>true</enabled>
      </snapshots>
    </repository>
  </repositories>

e.g. what is the version?

the snapshots are built from branch master, i added a badge to show the latest snapshot version. (the current uploaded snapshot package is pushed by myself manually)
Sonatype Nexus (Snapshots)

Signed-off-by: yue9944882 <291271447@qq.com>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 23, 2021
@brendandburns
Copy link
Contributor

/lgtm
/approve

Thanks for starting us towards GH action based automation!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [brendandburns,yue9944882]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@brendandburns
Copy link
Contributor

(we should probably expand this to the release branches also)

@k8s-ci-robot k8s-ci-robot merged commit 200768a into kubernetes-client:master Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants