Skip to content

Conversation

@brendandburns
Copy link
Contributor

When I did the release, I was a little confused with what was being requested, so I updated the descriptions with some examples.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 11, 2022
type: string
required: true
description: The next POM development version with suffix "-SNAPSHOT", will be the next development version after the release is done.
description: The next POM development version after the release is done. Must be of the form X.Y.${Z+1}-SNAPSHOT
Copy link
Member

@yue9944882 yue9944882 Jan 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brendandburns actually it is the default behavior of the maven release plugin but i kept this manual option on purpose in case we will bump a mid/minor version of the release sometime in the future. so for clarification it should be either X.${Y+1}.0-SNAPSHOT or X.Y.${Z+1}-SNAPSHOT, wdyt?

@yue9944882
Copy link
Member

@brendandburns bump ^^^^

Copy link
Member

@yue9944882 yue9944882 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

getting this in, let me clarify the detail in a follow-up

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2022
@k8s-ci-robot k8s-ci-robot merged commit 3372ec5 into kubernetes-client:master Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants