-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Support certificate based authentication from exec command #2170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support certificate based authentication from exec command #2170
Conversation
…n the kubeconfig. Add unit tests
|
|
|
Welcome @pgalache! |
|
@yue9944882 could you rerun the workflow? It seems there were some already existing flaky tests. I tested locally with JDK1.8 in Mac several times and it runs OK. In fact, the test that failed is code not affected by the changes in this PR: Edit: in fact I see it has also failed here when Mac was added to the matrix build. |
|
fwiw that MacOS failure was fixed in the PR before it merged, but I re-triggered testing and we'll see. |
yue9944882
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pgalache, yue9944882 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Implements #2157