Skip to content

Conversation

@rotty3000
Copy link

Signed-off-by: Raymond Augé raymond.auge@liferay.com

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 28, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: rotty3000 / name: Raymond Augé (dd8bab7)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 28, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @rotty3000!

It looks like this is your first PR to kubernetes-client/java 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/java has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 28, 2022
@brendandburns
Copy link
Contributor

fwiw, this file is code generated, but we set it to ignore a while ago and so we're not currently generating it.

For the time being, I'm ok merging this, but ultimately we should go back to generating this code.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 28, 2022
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 28, 2022
@rotty3000
Copy link
Author

@brendandburns I'm studying up on the generated code so that I can take that into consideration in future changes.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Mar 28, 2022
see kubernetes-client#2186

Signed-off-by: Raymond Augé <raymond.auge@liferay.com>
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Mar 28, 2022
@rotty3000
Copy link
Author

Please let me know if there is something else to be done here. I don't want to make further PRs without at least the first one fully processed :)

thx for your consideration.

@yue9944882
Copy link
Member

the edited file is already listed in the ignore list, so it's fine to append more edits directly. as a follow-up we should submit it the code-generater community.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2022
@brendandburns
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, rotty3000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2022
@k8s-ci-robot k8s-ci-robot merged commit c6b1f9e into kubernetes-client:master Mar 29, 2022
@rotty3000 rotty3000 deleted the issue2186 branch March 30, 2022 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants