-
Notifications
You must be signed in to change notification settings - Fork 2.1k
don't use internal gson package when JDK provides alternative #2187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
Welcome @rotty3000! |
|
fwiw, this file is code generated, but we set it to ignore a while ago and so we're not currently generating it. For the time being, I'm ok merging this, but ultimately we should go back to generating this code. |
|
@brendandburns I'm studying up on the generated code so that I can take that into consideration in future changes. |
see kubernetes-client#2186 Signed-off-by: Raymond Augé <raymond.auge@liferay.com>
|
Please let me know if there is something else to be done here. I don't want to make further PRs without at least the first one fully processed :) thx for your consideration. |
|
the edited file is already listed in the ignore list, so it's fine to append more edits directly. as a follow-up we should submit it the code-generater community. /lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, rotty3000 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Raymond Augé raymond.auge@liferay.com