Skip to content

add single argument constructor in Quantity #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2018
Merged

add single argument constructor in Quantity #223

merged 1 commit into from
Mar 28, 2018

Conversation

@mmmaks
Copy link
Contributor

@mmmaks mmmaks commented Mar 27, 2018

Adding single argument constructor in Quantity class, because of this issue : issue

@brendandburns
Copy link
Contributor

brendandburns commented Mar 28, 2018

@mmmaks the change looks good, but you need to sign the CNCF CLA

See:
https://github.com/kubernetes/community/blob/master/CLA.md#how-do-i-sign

For details.

Thanks!

@mmmaks
Copy link
Contributor Author

mmmaks commented Mar 28, 2018

Thanks,
Signed

@brendandburns
Copy link
Contributor

brendandburns commented Mar 28, 2018

LGTM. merging.

@brendandburns brendandburns merged commit 5d36c56 into kubernetes-client:master Mar 28, 2018
@karthikkondapally karthikkondapally mentioned this pull request Apr 3, 2018
Closed
@brendandburns brendandburns mentioned this pull request Apr 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mmmaks @brendandburns