Add default true to stdout and stderr on Exec. #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjeberhard
approved these changes
Apr 2, 2018
Contributor
rjeberhard
left a comment
rjeberhard
left a comment
There was a problem hiding this comment.
Thanks for pointing out what changed. I'm comfortable with this as one change. As a side note, I ran mvn fmt:format prior to my earlier push. How did we get \r\n line terminators in the file?
Contributor
Author
|
@rjeberhard I think I might have originally written this file on Windows, I think that they've been there all along... Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #225, though I would argue this is a breaking change for Kubernetes 1.9 and 1.10.
I'm going to try to repro and file a bug on upstream...
Sorry for the big diff. I also stripped
\r\nfrom the file, I can revert for a cleaner diff if that is preferred.The key diff is:
in
Exec.java@rjeberhard