Skip to content

Conversation

@hatsuyuki15
Copy link
Contributor

Hi, currently GCPAuthenticator support for environment without gcloud is broken. The code will throw NullPointerException when being executed:

Exception in thread "main" java.lang.NullPointerException
	at io.kubernetes.client.util.authenticators.GCPAuthenticator.refresh(GCPAuthenticator.java:103)
	at io.kubernetes.client.util.KubeConfig.getCredentials(KubeConfig.java:220)
	at io.kubernetes.client.util.credentials.KubeconfigAuthentication.<init>(KubeconfigAuthentication.java:59)
	at io.kubernetes.client.util.ClientBuilder.kubeconfig(ClientBuilder.java:299)
// Where exception is thrown
// File: util/src/main/java/io/kubernetes/client/util/authenticators/GCPAuthenticator.java

101:  if (this.gc == null) this.gc = GoogleCredentials.getApplicationDefault().createScoped(scopes);
102:  AccessToken accessToken = gc.getAccessToken();
103:  config.put(ACCESS_TOKEN, accessToken.getTokenValue());
104:  config.put(EXPIRY, accessToken.getExpirationTime());

The reason is that gc.getAccessToken() just returns the cached access token which is null initially. You have to explicitly call gc.refreshIfExpired() before to initialize it, as documented here

The current test for this functionality is broken too. Since it mocks getAccessToken(), it will never get null exception. However, it's quite hard to mock the correct behavior of Google Oauth2 Library, so I think I'll just attempt to fix the bug first. The fix for the test might come in another PR.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 10, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 10, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @hatsuyuki15!

It looks like this is your first PR to kubernetes-client/java 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/java has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 10, 2022
@brendandburns
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, hatsuyuki15

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2022
@k8s-ci-robot k8s-ci-robot merged commit 8b89747 into kubernetes-client:master Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants