Fix: GCPAuthenticator throws null exception in some cases #2276
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, currently GCPAuthenticator support for environment without
gcloudis broken. The code will throwNullPointerExceptionwhen being executed:The reason is that
gc.getAccessToken()just returns the cached access token which isnullinitially. You have to explicitly callgc.refreshIfExpired()before to initialize it, as documented hereThe current test for this functionality is broken too. Since it mocks
getAccessToken(), it will never get null exception. However, it's quite hard to mock the correct behavior of Google Oauth2 Library, so I think I'll just attempt to fix the bug first. The fix for the test might come in another PR.