-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Close ResponseBody in PodLogs on error #2314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
Welcome @adamjshook! |
|
/lgtm Thanks for the PR (and even more thanks for adding a unit test!) |
You're welcome! I fixed the checkstyle issue and pushed (maybe that wasn't necessary?). Could this be backported to the 12.x line for the next dot release or is that no longer being maintained? |
|
/lgtm If you send a cherry-pick PR against the release-12 branch we can cut a release for you. It's not really being maintained any more, but it's not very hard to cut a release now that we have automation to do it. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adamjshook, brendandburns The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #2310