Skip to content

Conversation

@adamjshook
Copy link
Contributor

Fixes #2310

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 15, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: adamjshook / name: Adam J. Shook (0afee92)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 15, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @adamjshook!

It looks like this is your first PR to kubernetes-client/java 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/java has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 15, 2022
@brendandburns
Copy link
Contributor

/lgtm
/approve

Thanks for the PR (and even more thanks for adding a unit test!)

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 15, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 15, 2022
@adamjshook
Copy link
Contributor Author

adamjshook commented Jul 15, 2022

Thanks for the PR (and even more thanks for adding a unit test!)

You're welcome! I fixed the checkstyle issue and pushed (maybe that wasn't necessary?).

Could this be backported to the 12.x line for the next dot release or is that no longer being maintained?

@brendandburns
Copy link
Contributor

/lgtm
/approve

If you send a cherry-pick PR against the release-12 branch we can cut a release for you. It's not really being maintained any more, but it's not very hard to cut a release now that we have automation to do it.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adamjshook, brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 333482a into kubernetes-client:master Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PodLogs is not closing Response on error

3 participants