Skip to content

Chore: Run spotless formatter #2316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2022
Merged

Chore: Run spotless formatter #2316

merged 1 commit into from
Jul 19, 2022

Conversation

@yue9944882
Copy link
Member

@yue9944882 yue9944882 commented Jul 19, 2022

No description provided.

@yue9944882
chore: run spotless formatter
0781f78 
Signed-off-by: yue9944882 <291271447@qq.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 19, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 19, 2022
@brendandburns
Copy link
Contributor

brendandburns commented Jul 19, 2022

/lgtm
/approve

Any ideas about how this slipped through?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [brendandburns,yue9944882]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit cbd9447 into kubernetes-client:master Jul 19, 2022
@yue9944882
Copy link
Member Author

yue9944882 commented Jul 25, 2022

Any ideas about how this slipped through?

@brendandburns i think the format failure is involved by #2315, the PR might be created/forked from a stale commit on the main branch which missed some future commits that bumped/upgraded formatter plugin. currrently the ci test (including format-checker) on each github PRs doesnt merge the main branch before running tests, i think thats why the unexpected formatter failure happened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

Assignees

@brendandburns brendandburns

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yue9944882 @brendandburns @k8s-ci-robot