-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add convert v1cronjob to v1job. #2373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
Welcome @6sco! |
|
/lgtm Thanks for sending a PR! |
|
Looks like you need to run |
Done. |
|
/lgtm Thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 6sco, brendandburns The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Turns out I ripped out the v1beta1 code for the 1.25 release anyway (#2385) and converted to V1CronJob So I think that this is no longer relevant. |
|
(unless we want to cherry-pick it into older releases) |
|
@6sco: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Closing this PR since it is no longer relevant. We'd still accept a cherry-pick of this PR into earlier release branches if you want. |
This PR will try to implement an acceptable approach for the following proposal #2368