Skip to content

Conversation

@mans2singh
Copy link
Contributor

Updated comment from List all of the namaspaces and pods to List all of the namespaces and pods

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 21, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @mans2singh!

It looks like this is your first PR to kubernetes-client/java 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/java has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 21, 2022
@mans2singh
Copy link
Contributor Author

@brendanburns @yue9944882 - I have this minor comment update PR, but the build / Java 8.0.x Maven Test on windows-latest is failing which is not related to the PR. Can you please let me know if I need to re-run the test and if so, how to do that ? Thanks

@brendandburns
Copy link
Contributor

@mans2singh if you push a new commit it will retrigger the tests.

Some of the tests are flaky (sorry!) so they fail unrelated to changes every once in a while.

@mans2singh
Copy link
Contributor Author

Thanks @brendandburns - Do you have any advice/recommendations of improvements for this minor PR or should I just push a simple commit just to trigger the build ?

Copy link
Member

@yue9944882 yue9944882 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 27, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mans2singh, yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2022
@k8s-ci-robot k8s-ci-robot merged commit 1c1fa09 into kubernetes-client:master Oct 27, 2022
@mans2singh
Copy link
Contributor Author

Thanks @brendandburns @yue9944882 for your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants