-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update examples-release-18 #2788
chore: update examples-release-18 #2788
Conversation
Welcome @Ananya2001-an! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Ananya2001-an The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
the |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
fixed example by #2800 /close please feel free to reopen if i missed anything |
@yue9944882: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Related to #2786
Corrected parameter count for few examples for release 18.0.1
Also added 2 more examples:
Additional context:
The client still remains open after executing a function; we can mitigate it by implementing the AutoCloseable interface and using a TWR block.
Also for some methods we are passing the
pretty
parameter as a String which I guess should be a Boolean IMO. Wdyt? We would have to change it everywhere tho...