Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update examples-release-18 #2788

Closed

Conversation

Ananya2001-an
Copy link
Member

Related to #2786
Corrected parameter count for few examples for release 18.0.1
Also added 2 more examples:

  • NamespaceList
  • ResourceQuotaList

Additional context:
The client still remains open after executing a function; we can mitigate it by implementing the AutoCloseable interface and using a TWR block.

Also for some methods we are passing the pretty parameter as a String which I guess should be a Boolean IMO. Wdyt? We would have to change it everywhere tho...

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 9, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @Ananya2001-an!

It looks like this is your first PR to kubernetes-client/java 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/java has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 9, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Ananya2001-an
Once this PR has been reviewed and has the lgtm label, please assign brendandburns for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ananya2001-an
Copy link
Member Author

the listPodsForAllNamespaces method in the latest 18.0.1 version is accepting only 10 parameters but in the CoreV1Api implementation of the method we have defined 11 params including sendInitialEvents. In the Javadoc as well we have mentioned only 10 params and it's producing results properly with 10 args...that's why the tests were failing in the last commit since the CoreV1Api implementation has 11 params defined...

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 26, 2023
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yue9944882
Copy link
Member

fixed example by #2800

/close

please feel free to reopen if i missed anything

@k8s-ci-robot
Copy link
Contributor

@yue9944882: Closed this PR.

In response to this:

fixed example by #2800

/close

please feel free to reopen if i missed anything

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Ananya2001-an Ananya2001-an deleted the update-examples-18 branch November 20, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants