-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shutdown original queue before override #3737
Conversation
Welcome @yuzp1996! |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, yuzp1996 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…al queue incase thread leakage Issue: kubernetes-client#3738 Signed-off-by: yuzhipeng <zpyu@alauda.io>
@brendandburns I have fixed the format error. Could you please take a look again and give your LGTM or approval? Thank you. |
Official Issue kubernetes-client#3738 Official PR kubernetes-client#3737 Signed-off-by: yuzhipeng <zpyu@alauda.io>
/lgtm |
6bc1880
into
kubernetes-client:master
When overriding the workQueue for the controller, the original queue must be shut down to avoid thread leakage. If the original queue is not shut down here, it will remain active even after the controller is shut down. This is because the controller's queue has been replaced by the newly created queue.
Related Issue: #3738