Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regenerate the Java code to pick up some fixes. #381

Merged
merged 1 commit into from
Oct 10, 2018
Merged

Regenerate the Java code to pick up some fixes. #381

merged 1 commit into from
Oct 10, 2018

Conversation

brendandburns
Copy link
Contributor

Fixes #378

@sha1n

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 9, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from mbohlool October 9, 2018 05:16
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 9, 2018
@sha1n
Copy link

sha1n commented Oct 9, 2018

Fixes #378

@sha1n

@brendandburns I believe you meant to tag someone else here :)

@brendandburns
Copy link
Contributor Author

Oops, sorry, I meant to tag: @cliveseldon

ukclivecox
ukclivecox reviewed Oct 10, 2018
View reviewed changes
Copy link
Contributor

@ukclivecox ukclivecox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The extra custom object status/scale methods seem to have been added.
  • I tested the Custom Object status get and replace and works for me

Look forward to seeing this merged.

@brendandburns brendandburns added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2018
@brendandburns
Copy link
Contributor Author

self-lgtm on the verification from @cliveseldon

@k8s-ci-robot k8s-ci-robot merged commit e3f7b18 into kubernetes-client:master Oct 10, 2018
@ukclivecox ukclivecox mentioned this pull request Oct 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ukclivecox ukclivecox ukclivecox left review comments

@mbohlool mbohlool Awaiting requested review from mbohlool

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brendandburns @k8s-ci-robot @sha1n @ukclivecox