Fix Watch.Response deserialization to preserve DynamicKubernetesObject raw data #4403
+91
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Watch.Response objects were not preserving the raw JSON data for DynamicKubernetesObject instances. The issue affected all event types (ADDED, MODIFIED, DELETED), despite the original report focusing on ADDED.
Root Cause
Watch.parseLine()calledjson.deserialize(), which uses the global static GSON instance. DynamicKubernetesApi registers DynamicKubernetesTypeAdaptorFactory on its ApiClient's GSON instance, but Watch wasn't using it.Changes
parseLine()to calljson.getGson().fromJson()directly instead ofjson.deserialize(), ensuring it uses the ApiClient-configured GSON instance with registered TypeAdaptersExample
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.