Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update snakeyaml to 1.25 #812

Merged
merged 1 commit into from
Nov 25, 2019

Conversation

eschrock
Copy link
Contributor

Fixes #811. Build and test using mvn install:

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Kubernetes Client API 7.0.0-SNAPSHOT:
[INFO] 
[INFO] Kubernetes Client API .............................. SUCCESS [  0.137 s]
[INFO] client-java-api .................................... SUCCESS [08:28 min]
[INFO] client-java-proto .................................. SUCCESS [ 30.305 s]
[INFO] client-java ........................................ SUCCESS [07:44 min]
[INFO] client-java-extended ............................... SUCCESS [01:59 min]
[INFO] client-java-examples ............................... SUCCESS [ 10.398 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  18:54 min
[INFO] Finished at: 2019-11-22T19:59:13-05:00
[INFO] ------------------------------------------------------------------------

Using program from #811 , what was previously failing now gets further, to the point of requiring additional reflect config:

$ ./target/io.titandata.app.app 
Exception in thread "main" java.lang.ExceptionInInitializerError
	at com.oracle.svm.core.hub.ClassInitializationInfo.initialize(ClassInitializationInfo.java:290)
	at java.lang.Class.ensureInitialized(DynamicHub.java:467)
	at okhttp3.OkHttpClient.<clinit>(OkHttpClient.java:124)
	at com.oracle.svm.core.hub.ClassInitializationInfo.invokeClassInitializer(ClassInitializationInfo.java:350)
	at com.oracle.svm.core.hub.ClassInitializationInfo.initialize(ClassInitializationInfo.java:270)
	at java.lang.Class.ensureInitialized(DynamicHub.java:467)
	at okhttp3.OkHttpClient$Builder.<init>(OkHttpClient.java:449)
	at io.kubernetes.client.openapi.ApiClient.init(ApiClient.java:91)
	at io.kubernetes.client.openapi.ApiClient.<init>(ApiClient.java:82)
	at io.kubernetes.client.util.ClientBuilder.build(ClientBuilder.java:295)
	at io.kubernetes.client.util.Config.defaultClient(Config.java:113)
	at io.titandata.app.App.main(App.java:14)
Caused by: java.nio.charset.UnsupportedCharsetException: UTF-32BE
	at java.nio.charset.Charset.forName(Charset.java:531)
	at okhttp3.internal.Util.<clinit>(Util.java:81)
	at com.oracle.svm.core.hub.ClassInitializationInfo.invokeClassInitializer(ClassInitializationInfo.java:350)
	at com.oracle.svm.core.hub.ClassInitializationInfo.initialize(ClassInitializationInfo.java:270)

In addition, we've been using this version of snakeyaml with the client in our testing for a while now without issue.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 23, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 23, 2019
@brendandburns
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, eschrock

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2019
@yue9944882
Copy link
Member

the bot seems stucked..

@yue9944882
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit c431055 into kubernetes-client:master Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use more recent version of snakeyaml to address bug affecting GraalVM native-image
4 participants