Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement OIDC Authentication Support #167

Merged
merged 1 commit into from
Jan 15, 2019
Merged

Implement OIDC Authentication Support #167

merged 1 commit into from
Jan 15, 2019

Conversation

brendandburns
Copy link
Contributor

Fixes #116

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 22, 2018
@brendandburns brendandburns requested review from itowlson and removed request for mbohlool January 11, 2019 23:08
@brendandburns
Copy link
Contributor Author

@itowlson can I get a review here?

itowlson
itowlson suggested changes Jan 12, 2019
View reviewed changes
Copy link
Contributor

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for the accessSync + exception swallowing change, which for me creates clutter. See comments in #168 for proposed solution to that.

src/config.ts Outdated
@@ -17,21 +17,29 @@ export class KubeConfig {
// Only public for testing.
public static findHomeDir(): string | null {
if (process.env.HOME) {
if (fs.existsSync(process.env.HOME)) {
try {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments on #168.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 15, 2019
@brendandburns
Copy link
Contributor Author

@itowlson rebased and resolved because #168 was merged. Please take another look.

Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, itowlson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@itowlson
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit a4f9d70 into kubernetes-client:master Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itowlson itowlson itowlson approved these changes

Assignees

@itowlson itowlson

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brendandburns @k8s-ci-robot @itowlson