Skip to content

chore: add cjihrig to OWNERS #2094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Dec 6, 2024

As discussed with @brendanburns via email.

Should I make a similar PR to the release-v1.x branch?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 6, 2024
@brendandburns
Copy link
Contributor

/verify-owners
/lgtm
/approve

@cjihrig I believe that this file is sufficient to be able to merge PRs to all branches in the repo. Let's see if it works, and if not, we can add it to the other branch.

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 6, 2024
@brendandburns
Copy link
Contributor

@cjihrig looks like you need to add yourself here:

https://github.com/kubernetes/org/blob/main/config/kubernetes-client/org.yaml#L16

Raise a PR, I will put my support on the PR. We may need to get @mstruebing to do the same.

Apologies for the bureacracy.

@cjihrig
Copy link
Contributor Author

cjihrig commented Dec 6, 2024

No worries. I've opened kubernetes/org#5295 and added you and @mstruebing (I hope that is OK. If not, it's totally fine.) as sponsors.

@mstruebing
Copy link
Member

I've put in my +1 for you, we should probably wait until it's accepted before merging this PR here.

@cjihrig
Copy link
Contributor Author

cjihrig commented Dec 7, 2024

Thank you @mstruebing

@cjihrig
Copy link
Contributor Author

cjihrig commented Dec 16, 2024

kubernetes/org#5295 has landed and I have joined the kubernetes-client org.

@mstruebing
Copy link
Member

/lgtm
/approve

Finally 🎉

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, cjihrig, mstruebing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [brendandburns,mstruebing]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cjihrig
Copy link
Contributor Author

cjihrig commented Dec 16, 2024

Not sure if this will work yet, but...

/verify-owners

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Dec 16, 2024
@k8s-ci-robot k8s-ci-robot merged commit 15c6ef8 into kubernetes-client:master Dec 16, 2024
2 checks passed
@cjihrig cjihrig deleted the owners-master branch December 16, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants