send keep-alive probes every 30 seconds to the server #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
bacongobbler
changed the title
This fix sends keep-alive probes to the server every 30 seconds. Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
k8s-ci-robot
added
size/M
added 2 commits
April 7, 2021 13:10
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
|
Pushing up the lint fixes now and it should be ready for testing. |
|
/lgtm Thanks! |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bacongobbler, brendandburns The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
3 tasks
Alabate
pushed a commit
to Alabate/kubernetes-client-javascript
that referenced
this pull request
Dec 28, 2024
This will send sends keep-alive probes to the server every 30 seconds. These features were present prior to the 1.0 refactor but were inadvertently removed. Fixes kubernetes-client#2127 Previous relevant issues: - Initial issue: kubernetes-client#559 - PR: kubernetes-client#630 - Improvement: kubernetes-client#632 - PR: kubernetes-client#635
Alabate
added a commit
to Alabate/kubernetes-client-javascript
that referenced
this pull request
Dec 28, 2024
This will send sends keep-alive probes to the server every 30 seconds. These features were present prior to the 1.0 refactor but were inadvertently removed. Fixes kubernetes-client#2127 Previous relevant issues: - Initial issue: kubernetes-client#559 - PR: kubernetes-client#630 - Improvement: kubernetes-client#632 - PR: kubernetes-client#635
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sends keep-alive probes to the server every 30 seconds, similar to client-go. This should help in samples such as the watch example, as now a keepalive header should be sent by the client to keep the connection open.
Note that this option will apply to only watch requests. Kubernetes' client-go sets this up during the construction of the
transport.Newwith a given client config, so I think theirs applies to all requests:https://github.com/kubernetes/client-go/blob/f6ce18ae578c8cca64d14ab9687824d9e1305a67/transport/transport.go#L46-L53
https://github.com/kubernetes/client-go/blob/f6ce18ae578c8cca64d14ab9687824d9e1305a67/transport/cache.go#L90-L96
It is possible that alternative features like the
Logwith thefollowoption enabled might need this flag as well.Signed-off-by: Matthew Fisher matt.fisher@microsoft.com