-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for more quantity units #757
Add support for more quantity units #757
Conversation
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @wejendorp! |
Adds support for missing decimal units: u, k, M, G, T, P and E. Fixes multiplier for nano from 1e-8 to 1e-9.
458f93b
to
25bda5f
Compare
@@ -42,7 +42,7 @@ const mockedPodMetrics: PodMetricsList = { | |||
window: '30s', | |||
containers: [ | |||
{ name: 'nginx', usage: { cpu: '0', memory: '4012Ki' } }, | |||
{ name: 'sidecar', usage: { cpu: '140000000n', memory: '3012Ki' } }, | |||
{ name: 'sidecar', usage: { cpu: '1400000000n', memory: '3012Ki' } }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding missing 0 to make tests pass w/ the nano 1e-8 -> 1e-9 change.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, wejendorp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@brendandburns when do you think it'll be possible to make a release from this? |
Please note I created this #758 since merging to master triggers a job that doesn't work |
@wejendorp I will push a release this week. |
@brendandburns bump, in case you forgot. |
A release would be super helpful as we are currently hitting the "Unknown suffix" exception. |
Adds support for missing decimal units: u, k, M, G, T, P and E.
Fixes multiplier for nano from 1e-8 to 1e-9.
Adds more units from #653, and should cover the full range of decimal units now.
Prevents the new
top
commands from crashing if any resource is using decimal units.