Add tls-server-name to https requests if provided

[tigrato]

This should address #887

cc @brendandburns

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: tigrato / name: Tiago Silva (3cda1bb)

[k8s-ci-robot]

Welcome @tigrato!

It looks like this is your first PR to kubernetes-client/javascript 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/javascript has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[brendandburns]

Thanks for the PR. I made one comment, also we should add a unit test to validate this.

[tigrato]

@brendandburns, thanks for the review.
I pushed unit tests for applyToRequest and applytoHTTPSOptions public functions!

[brendandburns]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, tigrato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [brendandburns]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment