This repository has been archived by the owner on Mar 13, 2022. It is now read-only.
fixing flipped sign in expiry time padding #55
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into a bug where any job that runs long enough for the API token to expire will fail with a
401 Unauthorized ApiException
. We found that this was due to a flipped sign in the padding added to the expiry. I've updated the_is_expired
method to returnTrue
if the token expires in 5 minutes, as opposed to the current logic which returnsTrue
if the token expired 5 minutes ago. I've also added an extra assertion to ensure that the_load_gcp_token
method actually updates the expiry timestamp.Please let me know if you have any questions or comments!