Skip to content
This repository has been archived by the owner on Mar 13, 2022. It is now read-only.

remove required idp-certificate-authority-data in kubeconfig for oidc… #69

Merged
merged 1 commit into from
Jun 6, 2018

Conversation

mvle
Copy link
Contributor

@mvle mvle commented May 25, 2018

… toke refresh, kubernetes-client/python#493

@codecov-io
Copy link

codecov-io commented May 25, 2018

Codecov Report

Merging #69 into master will increase coverage by 0.08%.
The diff coverage is 95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
+ Coverage   93.43%   93.51%   +0.08%     
==========================================
  Files          11       11              
  Lines         960      972      +12     
==========================================
+ Hits          897      909      +12     
  Misses         63       63
Impacted Files Coverage Δ
config/kube_config_test.py 93.51% <100%> (+0.19%) ⬆️
config/kube_config.py 89.77% <90%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5784a38...980f9b1. Read the comment docs.

@yliaog
Copy link
Contributor

yliaog commented Jun 6, 2018

/lgtm

@yliaog yliaog self-assigned this Jun 6, 2018
@yliaog yliaog merged commit 78472de into kubernetes-client:master Jun 6, 2018
@hanikesn
Copy link

hanikesn commented Jun 7, 2018

What about:

Why would you not verify the certificate just because it isn't specified?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants