Skip to content
This repository has been archived by the owner on Mar 13, 2022. It is now read-only.

Add support for refreshing Azure tokens. #77

Merged
merged 1 commit into from
Jul 23, 2018

Conversation

brendandburns
Copy link
Contributor

@roycaihw

This requires an update to the 'requirements.txt' to import the adal library, but it appears that is in a different repo?

@roycaihw is there advice for how to add dependencies?

Thanks!

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 20, 2018
@roycaihw
Copy link
Member

roycaihw commented Jul 20, 2018

We use tox to test python-base change with python HEAD. python/requirements.txt defines the required dependencies for the package. test-requirements.txt adds the dependencies used by CI testing.

@brendandburns
Copy link
Contributor Author

Thanks, filed kubernetes-client/python#579 for requirements.txt

client_id = config['client-id']
token_response = context.acquire_token_with_refresh_token(
refresh_token, client_id, '00000002-0000-0000-c000-000000000000')

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the CI pycodestyle complains about blank line containing whitespace

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed....

@codecov-io
Copy link

Codecov Report

Merging #77 into master will decrease coverage by 1.29%.
The diff coverage is 17.64%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #77     +/-   ##
=========================================
- Coverage   93.14%   91.85%   -1.3%     
=========================================
  Files          11       11             
  Lines         977      994     +17     
=========================================
+ Hits          910      913      +3     
- Misses         67       81     +14
Impacted Files Coverage Δ
config/kube_config.py 84.26% <17.64%> (-4.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7359cda...96767a3. Read the comment docs.

@roycaihw
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2018
@roycaihw roycaihw merged commit 24a0ff2 into kubernetes-client:master Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants