Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contribution 101 #266

Closed
mbohlool opened this issue Jun 21, 2017 · 9 comments · Fixed by #1031
Closed

Add contribution 101 #266

mbohlool opened this issue Jun 21, 2017 · 9 comments · Fixed by #1031
Assignees
Labels
kind/documentation Categorizes issue or PR as related to documentation. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@mbohlool
Copy link
Contributor

Add a contribution document explain the structure of the repo and best practices to start developing. Topics includes (but not limited to):

  • What is generated, semi-generated, and manual
  • What is base repo and how it is related to this repo
  • How to update generated client
  • What should be fixed in preprocessing script and what should be an upstream fix
  • What should be commit and how many commits my PR should have
@ebbeelsborg
Copy link

Perhaps also some guidelines on how and when one should write different types of tests (unit, integration, e2e...)?

@mbohlool
Copy link
Contributor Author

That is a good idea. I can start something and then we can all contribute to it.

@mbohlool mbohlool self-assigned this Jun 22, 2017
@mbohlool mbohlool removed their assignment Apr 15, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 14, 2019
@micw523
Copy link
Contributor

micw523 commented Jul 26, 2019

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 26, 2019
@roycaihw
Copy link
Member

/assign

@roycaihw roycaihw added kind/documentation Categorizes issue or PR as related to documentation. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Sep 11, 2019
@roycaihw
Copy link
Member

roycaihw commented Oct 1, 2019

What is generated, semi-generated, and manual
What is base repo and how it is related to this repo

The original design was https://github.com/kubernetes/community/blob/master/contributors/design-proposals/api-machinery/csi-new-client-library-procedure.md

Also it would be great if we have document around how to run tests in this repo. Ref: kubernetes-client/python-base#126 (comment)

@micw523
Copy link
Contributor

micw523 commented Oct 22, 2019

/assign

@scottilee
Copy link
Contributor

@micw523 any update on this and #910?

@roycaihw roycaihw removed their assignment Dec 2, 2019
@micw523
Copy link
Contributor

micw523 commented Dec 3, 2019

Thanks for the ping - it will be done - I just returned from a conference and regained my desktop.

@micw523 micw523 mentioned this issue Dec 13, 2019
4 tasks
yliaog pushed a commit to yliaog/client-python that referenced this issue Jan 8, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
[config] Add a new method of config.kube_config.new_client_from_config_dict
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants