-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update python-base #1161
update python-base #1161
Conversation
Welcome @zshihang! |
/assign @yliaog |
It looks like the tests are failing https://travis-ci.org/github/kubernetes-client/python/jobs/683532228:
Travis ci is having trouble reporting the result back to github, but it's still visible in travis. We need to make sure the tests are green before merging |
i have run locally and it is passing. python -m unittest discover
...
Running test against : https://192.168.9.2:8443
...
Ran 1617 tests in 37.708s
OK i'll rebase and try again. |
I think the failing ones are e2e tests, which aren't covered by the unittest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roycaihw, zshihang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fixes #616
the python-base changes include: