e2e: use labels for configmap api; wait for default service account creation #1348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roycaihw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
roycaihw
force-pushed
the
configmap-e2e/labels
branch
3 times, most recently
from
3849ad9 to
866fe44
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
There are some new test failure regarding the |
roycaihw
force-pushed
the
configmap-e2e/labels
branch
from
866fe44 to
3b95adc
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
lgtm
roycaihw
force-pushed
the
configmap-e2e/labels
branch
3 times, most recently
from
2b7af1b to
09a4935
Compare
|
(fixed some syntax error) The tests pass now https://travis-ci.org/github/kubernetes-client/python/builds/754195162. /hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
yliaog
reviewed
Jan 13, 2021
| @@ -65,6 +72,23 @@ def test_pod_apis(self): | |||
|
|
|||
| name = 'busybox-test-' + short_uuid() | |||
| pod_manifest = manifest_with_command(name, "while true;do date;sleep 5; done") | |||
|
|
|||
| # wait for the default service account to be created | |||
There was a problem hiding this comment.
better to give a timeout than wait forever
There was a problem hiding this comment.
done
/hold
wait for test results
There was a problem hiding this comment.
/hold cancel
The test is green
| @@ -130,6 +154,23 @@ def test_exit_code(self): | |||
|
|
|||
| name = 'busybox-test-' + short_uuid() | |||
| pod_manifest = manifest_with_command(name, "while true;do date;sleep 5; done") | |||
|
|
|||
| # wait for the default service account to be created | |||
roycaihw
force-pushed
the
configmap-e2e/labels
branch
from
09a4935 to
6deaaf8
Compare
k8s-ci-robot
added
the
do-not-merge/hold
roycaihw
changed the title
roycaihw
force-pushed
the
configmap-e2e/labels
branch
from
6deaaf8 to
9093103
Compare
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm thanks for fixing it. |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Bound Service Account Tokens feature creates a configmap
kube-root-ca.crtin every namespace. Use a label to select the test objects we create.Also wait for the default service account to be created before creating pods that need it.
/hold
wait for the tests to pass
The submodule update contains two commits, which do not require CHANGELOG change:
dynamic/test_client.py::TestDynamicClient::test_configmap_apisref kubernetes-client/python-base#222, #1347