-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Upgrades the openapi python client to v6.2.1 #1887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrades the openapi python client to v6.2.1 #1887
Conversation
@spacether: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @spacether! |
i think we should not be using the experimental generator. please file a PR to use the official generator release. |
@yliaog I just updated this PR to use the official 6.2.0 python generator |
@yliaog can you or others review this PR? Do I need to do anything else? |
could you please squash the commits? I'll take a look afterwards. Thanks. |
c4e18f9
to
6a1414f
Compare
@yliaog just squashed them into one commit now |
so this PR introduces breaking change? for breaking change, we need to solicit community feedback. also it's better to split the PR into at least two commits, one commit for generated files, the other commit is for the manual edited files. |
Yes the updated client has breaking changes versus the old ones. I have not manually edited files. |
https://github.com/kubernetes-client/gen/tree/master/openapi needs manual update? please send email to: file an issue similar to: #974 |
My plan is to wait until 6.2.1 is released to get community feedback |
sounds good. thanks. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: spacether The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
… gen_kube_client so the different templating engine can be used
49bd4f1
to
aae3f84
Compare
Just posted an email in |
@spacether Could you update examples/ and e2e tests? |
@tomplus can you help me with my tox requirement installation? |
@spacether: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Any update on this? openapi-generator v6.3.0 is released already. |
I need help getting tox working. Until someone helps this is stalled. Also openapi-generator has announced that the current python generator will be replaced with the python-nextgen generator in v 7.0.0 |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
What type of PR is this?
/kind feature
/kind api-change
What this PR does / why we need it:
This PR switches to using the python generator from openapi-generator v6.2.1
Please do not review this PR into I move it out of WIP/Draft State
This PR updates the python client which now has:
I am seeking feedback from your project on what you think about the python client in the latest openapi-generator and if you prefer to use it going forward.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I am seeking feedback from your project on how you feel about using the code generated from the 6.2.1 python generator.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: