Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting upper version bound for urllib3 #2105

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Setting upper version bound for urllib3 #2105

merged 1 commit into from
Aug 23, 2023

Conversation

jsaalfeld
Copy link
Contributor

@jsaalfeld jsaalfeld commented Aug 23, 2023 •
edited
Loading

Since google-auth doesn't support urllib3>2.0 (googleapis/google-auth-library-python#1365), an upper version bound for urllib3 needs to be set. Otherwise the package is not installable, since the dependency to google-auth breaks.

What type of PR is this?

/kind bug

What this PR does / why we need it:

It fixed breaking dependencies.

Does this PR introduce a user-facing change?

NONE


fix upper version boundary of urllib3, since other dependencies don't support urllib3 in version 2

@jsaalfeld
Setting upper version bound for urllib3
27459d5 
Since google-auth doesn't support urllib3>2.0 (googleapis/google-auth-library-python#1365), an upper version bound for urllib3 needs to be set. Otherwise the package is not installable, since the dependency to google-auth breaks.
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 23, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 23, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: jsaalfeld / name: Jochen Saalfeld (27459d5)

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 23, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @jsaalfeld!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 23, 2023
@yliaog
Copy link
Contributor

yliaog commented Aug 23, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsaalfeld, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit ae7b5dd into kubernetes-client:master Aug 23, 2023
8 checks passed
@yliaog yliaog mentioned this pull request Aug 30, 2023
Closed
hauntsaninja added a commit to hauntsaninja/python that referenced this pull request Oct 4, 2023
@hauntsaninja
Drop urllib3 upper bound
af68284 
This was added in kubernetes-client@27459d5.

Note that google-auth now requires urllib3>=2 in googleapis/google-auth-library-python#1389

(I'm also not sure that I follow the logic in kubernetes-client#2105, since dependency resolvers will be able to work it out)
@hauntsaninja hauntsaninja mentioned this pull request Oct 4, 2023
Merged
dirrao pushed a commit to dirrao/python that referenced this pull request Nov 28, 2023
@hauntsaninja
Drop urllib3 upper bound
9deb4fe 
This was added in kubernetes-client@27459d5.

Note that google-auth now requires urllib3>=2 in googleapis/google-auth-library-python#1389

(I'm also not sure that I follow the logic in kubernetes-client#2105, since dependency resolvers will be able to work it out)
bh717 pushed a commit to bh717/python-dapp that referenced this pull request Apr 1, 2024
Drop urllib3 upper bound
fe525ea 
This was added in kubernetes-client/python@27459d5.

Note that google-auth now requires urllib3>=2 in googleapis/google-auth-library-python#1389

(I'm also not sure that I follow the logic in kubernetes-client/python#2105, since dependency resolvers will be able to work it out)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roycaihw roycaihw Awaiting requested review from roycaihw

@yliaog yliaog Awaiting requested review from yliaog

Assignees

@yliaog yliaog

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsaalfeld @k8s-ci-robot @yliaog