-
Notifications
You must be signed in to change notification settings - Fork 3.3k
binary websocket support, plus examples #494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think I've successfully patched swagger in swagger-api/swagger-codegen@676da33 although my tests aren't supported by a successful CI run because starting branch obsolescence. Basically I'm using six.binary_type that translate to I'll work on testing against our needs but seems promising ! |
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hello, in #476 we noted that we currently cannot stream binary data to/from pods so no feature like
kubectl cp
(and probably others) could be implemented.I've worked on that, two PR came out. The first is kubernetes-client/python-base#52 and when it will be merged, this one will then unlock binary streams and provide couple examples on how to do it.
Problem: I had to patch core_v1_api.py swagger generated code, as swagger itself seems to ignore binary type specification. I'm currently investigating on that.
In the meanwhile I could produce a temporary patch in
scripts/
and apply it whenclient-update
ing but I'd like to know what do you think about that part.Thank you, ciao