Skip to content

binary websocket support, plus examples #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

binary websocket support, plus examples #494

wants to merge 2 commits into from

Conversation

aogier
Copy link

@aogier aogier commented Mar 24, 2018

Hello, in #476 we noted that we currently cannot stream binary data to/from pods so no feature like kubectl cp (and probably others) could be implemented.

I've worked on that, two PR came out. The first is kubernetes-client/python-base#52 and when it will be merged, this one will then unlock binary streams and provide couple examples on how to do it.

Problem: I had to patch core_v1_api.py swagger generated code, as swagger itself seems to ignore binary type specification. I'm currently investigating on that.
In the meanwhile I could produce a temporary patch in scripts/ and apply it when client-updateing but I'd like to know what do you think about that part.

Thank you, ciao

@aogier
Copy link
Author

aogier commented Mar 24, 2018

I think I've successfully patched swagger in swagger-api/swagger-codegen@676da33 although my tests aren't supported by a successful CI run because starting branch obsolescence.

Basically I'm using six.binary_type that translate to str on py2 (no-op), and bytes on py3 and this need to be checked throughly against py3 tests in python-base (afaict python-client tests are empty, and for sure they return OK).

I'll work on testing against our needs but seems promising !

@fejta-bot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/check-cla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 20, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 20, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 19, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants