regenerate client code with latest k8s api #682

eastlondoner · 2018-11-05T15:23:28Z

So that it is compatible with python 3.7

roycaihw · 2018-11-07T01:23:12Z

The python 3.7 support issue was about the reserved keyword workaround. It's not related to Kubernetes API (openapi spec). We already have two GA releases that support Python 3.7 (v7.0.0 and v8.0.0). Please try the new versions out.

I don't see strong reason for re-generating v6 client against Kubernetes release-1.10 spec. Closing

/close

k8s-ci-robot · 2018-11-07T01:23:14Z

@roycaihw: Closing this PR.

In response to this:

Please see #584 (comment).

The python 3.7 support issue was about the reserved keyword workaround. It's not related to Kubernetes API (openapi spec). We already have two GA releases that support Python 3.7 (v7.0.0 and v8.0.0). Please try the new versions out.

I don't see strong reason for re-generating v6 client against Kubernetes release-1.10 spec. Closing

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

roycaihw · 2018-11-07T01:31:07Z

More thoughts on this:

Kubernetes supports three minor releases at the same time. Currently it's 1.10, 1.11 and 1.12. This python client repo follows similar policy and we currently support v6, v7 and v8. Kubernetes v1.13.0 is planned to be released in less a month (Dec. 3rd). After k8s 1.13 is released, 1.10 will not be supported, and we will start releasing python client v9 and dropping v6.

At this point, given the short period of supporting 1.10, I'd suggest switching to more recent versions of Kubernetes, instead of releasing a python client v6.0.1 to support Python 3.7

[update] Also please take a look at #681 (comment). Please try 7.0.0 release to see if it works better with k8s 1.10 apiserver

eastlondoner · 2018-11-07T08:20:03Z

@roycaihw

The python 3.7 support issue was about the reserved keyword workaround.

Yes. In order to get the fix for the reserved keyword it is necessary to do what I have done in this PR - do you disagree?

We already have two GA releases that support Python 3.7 (v7.0.0 and v8.0.0).

I would like to use python 3.7 with v6 because I want to use K8 1.10 which is supposed to be supported now.

At this point, given the short period of supporting 1.10, I'd suggest switching to more recent versions of Kubernetes, instead of releasing a python client v6.0.1 to support Python 3.7

I suggest that you merge my PR and support all the versions of K8s that are supposed to be supported.

That sounds good in principle. We are using hosted Kubernetes with GCP and 1.11 has only been available for general use for less than a week, we need some time to ensure that we can move to 1.11 without problems.

Do you have an actual reason not to merge this PR?

roycaihw

@eastlondoner Fair enough. This covers a gap in our support for Kubernetes 1.10 with Python 3.7.

Please add a section to the CHANGELOG noting what's changed in v6.1.0 (actually bumping minor version number is not enough, as we are introducing breaking change here):

Breaking Change:
- ACTION REQUIRED Rename the currently being-used async parameter to async_req to support Python 3.7 because it's a reserved keyword in Python 3.7 feat: support for 3.7 (workaround) gen#67
  NOTE that Python 3.7 was released after v6.0.0 release. Please DON'T upgrade your client to v6.1.0 if you do not use Python 3.7.
API Change:
- Add custom object status and scale api Add custom object status and scale api gen#72

Once we merge this PR we can start making Pypi distribution packages and Github release page.

/cc @yliaog

roycaihw · 2018-11-07T22:09:41Z

kubernetes/README.md

 ```
-(you may need to run `pip` with root permission: `sudo pip install git+https://github.com/kubernetes-client/python.git`)
+(you may need to run `pip` with root permission: `sudo pip install git+https://github.com/kubernetes-kubernetes.client/python.git`)


Please manually restore the commands in L20 and L22. I believe we have some misconfig of automation/swagger-codegen that writes the extra kubernetes.

roycaihw · 2018-11-07T22:15:47Z

kubernetes/swagger.json.unprocessed

@@ -79877,7 +79877,7 @@
          "type": "string"
        },
        "mountPropagation": {
-          "description": "mountPropagation determines how mounts are propagated from the host to container and the other way around. When not set, MountPropagationHostToContainer is used. This field is beta in 1.10.",
+          "description": "mountPropagation determines how mounts are propagated from the host to container and the other way around. When not set, MountPropagationNone is used. This field is beta in 1.10.",


Looks like there is no significant api change from openapi spec :)

eastlondoner · 2018-11-08T10:36:30Z

Thanks @roycaihw.
I have updated the README, CHANGELOG, setup.py and tox.ini

micw523 · 2018-11-08T14:58:44Z

tox.ini

+commands =
+   python -V
+   {toxinidir}/scripts/kube-init.sh py.test -vvv -s []
+


I’m not sure we test Python 3.7 functional in our Travis CI even in the master branch. Also, I’m not sure if official support for Travis CI has been extended to Python 3.7. See the most recent Travis build.

Need confirmation from @roycaihw

See build #1069 https://travis-ci.org/kubernetes-client/python/builds/452318635?utm_source=github_status&utm_medium=notification

ah, well I guess this is future proof at least

We haven't supported Python 3.7 in our travis-ci yet. Please see #584

Changes (tox.ini and .travis.yml) need to be checked into master branch in both python and python-base. I'm more comfortable with having separate PRs for those changes and this PR including necessary client re-generation. WDYT?

Me too. I prefer to wait to see Travis CI support Python 3.7 and make sure the keywords are correct, and then check them into the master branch.

roycaihw · 2018-11-08T18:51:34Z

I realized that I missed mentioning the step to update version constant. Please regenerate the client with the following steps:

update CLIENT_VERSION in scripts/constants.py to be 6.1.0 (ref: https://github.com/kubernetes-client/python/blob/master/devel/release.md#update-release-tags)
run scripts/update-client.sh and remove the extra "kubernetes." in README (swagger-codegen will update the client versions for you, so you don't have to manually change them)
add release note to CHANGELOG

eastlondoner · 2018-11-08T20:50:46Z

Done.
I reverted and started over. Changes are in a single commit. No changes to tox.ini

roycaihw · 2018-11-08T22:12:14Z

/lgtm

yliaog · 2018-11-08T23:51:00Z

/lgtm

roycaihw · 2018-11-08T23:58:35Z

/approve

k8s-ci-robot · 2018-11-08T23:58:37Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: eastlondoner, roycaihw
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: caesarxuchao

If they are not already assigned, you can assign the PR to them by writing /assign @caesarxuchao in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

eastlondoner · 2018-11-09T09:56:11Z

Thanks :-D this helps us to upgrade our stack smoothly as we work towards 1.11

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 5, 2018

k8s-ci-robot requested review from caesarxuchao and lavalamp November 5, 2018 15:23

k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 5, 2018

This was referenced Nov 5, 2018

8.0 branch has support for python 3.7 but 6.0 branch doesn't #681

Closed

Add Python 3.7 support to Travis CI testing #584

Closed

Problem with python 3.7 and "async" as parameter name #558

Closed

k8s-ci-robot closed this Nov 7, 2018

roycaihw reopened this Nov 7, 2018

k8s-ci-robot requested a review from yliaog November 7, 2018 22:46

roycaihw reviewed Nov 7, 2018

View reviewed changes

micw523 reviewed Nov 8, 2018

View reviewed changes

eastlondoner force-pushed the release-6.0-py37 branch from ce7715a to 2e90425 Compare November 8, 2018 20:46

Bump version to 6.1.0. Regenerate client code. Add to CHANGELOG

443894a

eastlondoner force-pushed the release-6.0-py37 branch from 2e90425 to 443894a Compare November 8, 2018 20:48

k8s-ci-robot assigned roycaihw Nov 8, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2018

k8s-ci-robot assigned yliaog Nov 8, 2018

roycaihw merged commit 6bcca10 into kubernetes-client:release-6.0 Nov 8, 2018

micw523 mentioned this pull request Nov 9, 2018

REQUEST: New membership for micw523 kubernetes/org#232

Closed

6 tasks

jillr mentioned this pull request Dec 4, 2019

K8s older_openshift_fail tests fail on python>=3.7 ansible/ansible#65524

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

regenerate client code with latest k8s api #682

regenerate client code with latest k8s api #682

eastlondoner commented Nov 5, 2018 •

edited

Loading

roycaihw commented Nov 7, 2018

k8s-ci-robot commented Nov 7, 2018

roycaihw commented Nov 7, 2018 •

edited

Loading

eastlondoner commented Nov 7, 2018 •

edited

Loading

roycaihw left a comment

roycaihw Nov 7, 2018

roycaihw Nov 7, 2018

eastlondoner commented Nov 8, 2018

micw523 Nov 8, 2018

micw523 Nov 8, 2018

eastlondoner Nov 8, 2018

roycaihw Nov 8, 2018

micw523 Nov 8, 2018

roycaihw commented Nov 8, 2018

eastlondoner commented Nov 8, 2018

roycaihw commented Nov 8, 2018

yliaog commented Nov 8, 2018

roycaihw commented Nov 8, 2018

k8s-ci-robot commented Nov 8, 2018

eastlondoner commented Nov 9, 2018

regenerate client code with latest k8s api #682

regenerate client code with latest k8s api #682

Conversation

eastlondoner commented Nov 5, 2018 • edited Loading

roycaihw commented Nov 7, 2018

k8s-ci-robot commented Nov 7, 2018

roycaihw commented Nov 7, 2018 • edited Loading

eastlondoner commented Nov 7, 2018 • edited Loading

roycaihw left a comment

Choose a reason for hiding this comment

roycaihw Nov 7, 2018

Choose a reason for hiding this comment

roycaihw Nov 7, 2018

Choose a reason for hiding this comment

eastlondoner commented Nov 8, 2018

micw523 Nov 8, 2018

Choose a reason for hiding this comment

micw523 Nov 8, 2018

Choose a reason for hiding this comment

eastlondoner Nov 8, 2018

Choose a reason for hiding this comment

roycaihw Nov 8, 2018

Choose a reason for hiding this comment

micw523 Nov 8, 2018

Choose a reason for hiding this comment

roycaihw commented Nov 8, 2018

eastlondoner commented Nov 8, 2018

roycaihw commented Nov 8, 2018

yliaog commented Nov 8, 2018

roycaihw commented Nov 8, 2018

k8s-ci-robot commented Nov 8, 2018

eastlondoner commented Nov 9, 2018

eastlondoner commented Nov 5, 2018 •

edited

Loading

roycaihw commented Nov 7, 2018 •

edited

Loading

eastlondoner commented Nov 7, 2018 •

edited

Loading