Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use yaml.safe_load #719

Merged
merged 1 commit into from
Jan 9, 2019
Merged

Use yaml.safe_load #719

merged 1 commit into from
Jan 9, 2019

Conversation

ramnes
Copy link
Contributor

@ramnes ramnes commented Jan 8, 2019

See #718 for rationale.

@micw523

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 8, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 8, 2019
@micw523
Copy link
Contributor

micw523 commented Jan 8, 2019

Could you leave the one in utils in its original form just for now? #673 will change the use of load into load_all which should be fine when it gets merged. The other two look good to me.

@ramnes
Copy link
Contributor Author

ramnes commented Jan 8, 2019

@micw523 If you change #673 to use safe_load_all rather than load_all, then yes! Otherwise, I can just rebase on your PR when it's inside the tree.

@micw523
Copy link
Contributor

micw523 commented Jan 8, 2019

@ramnes sounds good! I'll make the change in #673.

micw523 added a commit to micw523/python that referenced this pull request Jan 8, 2019
@micw523
Use safe YAML loading method safe_load_all
fe2f853 
Refer to kubernetes-client#719
@ramnes
Copy link
Contributor Author

ramnes commented Jan 9, 2019

@micw523 done

@yliaog
Copy link
Contributor

yliaog commented Jan 9, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 9, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ramnes, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2019
@k8s-ci-robot k8s-ci-robot merged commit 430544b into kubernetes-client:master Jan 9, 2019
@micw523 micw523 mentioned this pull request Mar 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roycaihw roycaihw Awaiting requested review from roycaihw

@yliaog yliaog Awaiting requested review from yliaog

Assignees

@yliaog yliaog

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ramnes @micw523 @yliaog @k8s-ci-robot @yekoprogram