-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken dependencies. #816
Conversation
All our libraries that depended on `kubernetes` started breaking today. The reason is that pip does not do a good job properly resolving the compatible package versions. It just install packages in order without caring about the incompatibilities. The urllib3 package installed is incompatible with the `requests` package that's getting installed later. Changing the order fixes the issue.
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
please sign CLA |
@Ark-kun can you sign the CLA? |
I signed it |
/cc @yliaog |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun, yliaog The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
All our libraries that depended on
kubernetes
started breaking today.The reason is that pip does not do a good job properly resolving the compatible package versions.
It just install packages in order without caring about the incompatibilities.
The urllib3 package installed is incompatible with the
requests
package that's getting installed later.Changing the order fixes the issue.
See kubeflow/pipelines#1201
Log illustrating the issue:
Then the packages fail at runtime.