Fix a bug parsing kubeconfig if the user context was empty string.

[brendandburns]

@drubin

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [brendandburns]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[drubin]

Just FYI you can do context['user'] = find_user(context['user']) if context['user'].blank? Then you should be able to keep the line the same.

https://stackoverflow.com/questions/885414/a-concise-explanation-of-nil-v-empty-v-blank-in-ruby-on-rails

I don't think it matters too much but if you do keep the if block can we remove the 2nd if check its kinda redundant and makes it harder to read.

[drubin]

Also, I think it would solve the rubocop warnings too :)

[brendandburns]

@drubin looks like blank? is in Rails, but not core Ruby, so we have to keep it like this for now...

(and using an if suffix here makes the line too long.

[brendandburns]

@drubin friendly ping on this one if you're around.

Thanks!

[drubin]

@brendandburns sorry been a busy week. Also sorry about the .blank? being rails only I always forget what they add for you.

/lgtm