-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make use of make container target from the release tools #146
Conversation
at present the makefile holds a target to make the container which is used by github actions like trivvy and also from the release process. This commit add the container only for testing and leaving rest of the process to the release tools Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
ce26141 Merge pull request kubernetes-csi#40 from humblec/dep-update 46a11db update dependencies and go version 7f4f7cc Merge pull request kubernetes-csi#39 from humblec/new-changes 8566b12 iscsi library fixes based on the csi-driver-iscsi c7bdbc5 Merge commit '706bbe0f1f5d43be335f2439f05fc15a8c372f32' into make-sync 0e71e17 Merge pull request kubernetes-csi#38 from humblec/new-1 676c6e5 Merge commit '67e5053588f954d534c3fae7f9d65116f0baee43' into make-sync abf0d0a Correct the formatting issue in iscsiadm ListInterface bb8cceb chore: fix gofmt 57f5817 add codespell linter to the github workflow actions f6582f6 update: pick latest kube release for alpha version 366f319 Merge pull request kubernetes-csi#35 from humblec/rel-alpha1 83b78f5 Merge pull request kubernetes-csi#36 from humblec/owners 56f04a2 make sure the mountTargetDevice in the connector is non nil 30b6cf3 various linter corrections and code cleanup 83dec6e update OWNERS file ad94dad correct codespell errors in the imported library git-subtree-dir: pkg/lib/iscsi git-subtree-split: ce2614163c72a5358a3f24e839ce55ff6f0a30c9
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
13221c9
to
158ba8d
Compare
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
158ba8d
to
e7cb6cf
Compare
d24254f Merge pull request kubernetes-csi#202 from xing-yang/kind_0.14.0 0faa3fc Update to Kind v0.14.0 images ef4e1b2 Merge pull request kubernetes-csi#201 from xing-yang/add_1.24_image 4ddce25 Add 1.24 Kind image 7fe5149 Merge pull request kubernetes-csi#200 from pohly/bump-kubernetes-version 70915a8 prow.sh: update snapshotter version 31a3f38 Merge pull request kubernetes-csi#199 from pohly/bump-kubernetes-version 7577454 prow.sh: bump Kubernetes to v1.22.0 d29a2e7 Merge pull request kubernetes-csi#198 from pohly/csi-test-5.0.0 41cb70d prow.sh: sanity testing with csi-test v5.0.0 c85a63f Merge pull request kubernetes-csi#197 from pohly/fix-alpha-testing b86d8e9 support Kubernetes 1.25 + Ginkgo v2 ab0b0a3 Merge pull request kubernetes-csi#192 from andyzhangx/patch-1 7bbab24 Merge pull request kubernetes-csi#196 from humblec/non-alpha e51ff2c introduce control variable for non alpha feature gate configuration ca19ef5 Merge pull request kubernetes-csi#195 from pohly/fix-alpha-testing 3948331 fix testing with latest Kubernetes e4dab7f Merge pull request kubernetes-csi#194 from yselkowitz/registry-k8s-io 84a4d5a Move from k8s.gcr.io to registry.k8s.io 9a0260c fix boilerplate header 37d1104 Merge pull request kubernetes-csi#191 from pohly/go-1.18 db917f5 update to Go 1.18 335339f Merge pull request kubernetes-csi#187 from mauriciopoppe/remove-eol-windows-versions 890b87a Merge pull request kubernetes-csi#188 from pwschuurman/update-release-notes-docs 274bc9b Update Sidecar Release Process documentation to reference latest syntax for release-notes tool 87b6c37 Merge pull request kubernetes-csi#185 from Garima-Negi/fix-OWNERS-files f1de2c6 Fix OWNERS file - squashed commits 59ae38b Remove EOL windows versions from BUILD_PLATFORMS 5d66471 Merge pull request kubernetes-csi#186 from humblec/sp d066f1b Correct prow.sh typo and make codespell linter pass 762e22d Merge pull request kubernetes-csi#184 from pohly/image-publishing-troubleshooting 81e26c3 SIDECAR_RELEASE_PROCESS.md: add troubleshooting for image publishing git-subtree-dir: release-tools git-subtree-split: d24254f
c5fa19b
to
2f59d85
Compare
verify-test failure. we can ignore trivvy failure for now though |
05c9cbf
to
b014452
Compare
e90e893
to
2a4cd01
Compare
/assign @andyzhangx |
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2a4cd01
to
b3db40c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, humblec The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
at present the makefile holds a target to make the container which is used by github actions like trivvy and also from the release process. This commit add the container only for testing and leaving rest of the process to the release tools
Signed-off-by: Humble Chirammal hchiramm@redhat.com
-->