Is it possible to implement snapshot functionality for nfs csi driver

[LilyaBu]

Hello! Is it possible to implement snapshot functionality for nfs csi driver? May be same as hostpath csi driver.

[wozniakjan]

Hi, I believe it could be possible but at the moment there is no plan to implement that quite yet. But if you'd like to take a stab at it, I will happily support you and review the code to get that merged.

[LilyaBu]

Thank you. I interested in csi nfs because i would like to backup/restore persistent volumes as cluster resources, not as app resource. As i understand this can be realised with StorageClass objects.

[wozniakjan]

In the whole scheme of things, StorageClass definitely plays an important role, but it is rather connected with another feature - dynamic provisioning of PVs.

Snapshots introduce own set of resources, https://kubernetes-csi.github.io/docs/snapshot-restore-feature.html is a great document to understand how snapshots under CSI work. This plugin will then need to figure out how to talk to the NFS server about supporting the second part of snapshots. This is probably the tricky bit, there was similar effort in OpenStack with cinder volumes https://specs.openstack.org/openstack/cinder-specs/specs/mitaka/nfs-snapshots.html, perhaps some of the ideas may apply here as well and could be reused.

[LilyaBu]

Thank you for links and explanation.

[wozniakjan]

/reopen
/assign

#30 (comment) discusses an alternative direction to implementing snapshots. I could see myself finding a little bit of time in following weeks to give that a shot.

[k8s-ci-robot]

@wozniakjan: Reopened this issue.

In response to this:

/reopen
/assign

#30 (comment) discusses an alternative direction to implement snapshots. I could see myself finding a little bit of time in following weeks to give that a shot.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[wozniakjan]

/remove-lifecycle rotten
hoping to have some time in September finally to work on this. Especially since there is some advancement on #30

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[guleng]

@wozniakjan Has the snapshot function been implemented for storage where NFS becomes PV?

[wozniakjan]

@guleng no, I couldn't find time, my apologies

[kamzata]

+1

[navilg]

+1

[fontexD]

+1

[chaotec]

+1

[mehdi-wsc]

+1

[wozniakjan]

/reopen

[k8s-ci-robot]

@wozniakjan: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[wozniakjan]

resurrecting from the rotten land, taking a first small step by proposing a draft on volume-to-volume cloning #426. If cp -a is an acceptable approach, would like to continue with proposing snapshots as tarballs stored in appropriate path on the NFS server, clone from snapshots could be similarly trivial then as untar to a proper PVC path.

[fontexD]

Sounds look a good idea!

[wozniakjan]

/remove-lifecycle rotten

[wozniakjan]

#426 merged, I will try to see if I can implement and propose tar and untar snapshots now

[wozniakjan]

I would like to continue and propose the tarball snapshots in #430, any comments and ideas are welcome.

[wozniakjan]

Basic snapshots as tarballs are implemented. Not the most efficient solution but it is a solution nevertheless and at the moment, afaik pure NFS doesn't have room for anything substantially better.

proposing to
/close

[k8s-ci-robot]

@wozniakjan: Closing this issue.

In response to this:

Basic snapshots as tarballs are implemented. Not the most efficient solution but it is a solution nevertheless and at the moment, afaik pure NFS doesn't have room for anything substantially better.

proposing to
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.