Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vendor to k8s 1.19 and csi-lib-utils to 0.9.0 #110

Merged
merged 1 commit into from
Dec 1, 2020
Merged

Update vendor to k8s 1.19 and csi-lib-utils to 0.9.0 #110

merged 1 commit into from
Dec 1, 2020

Conversation

msau42
Copy link
Collaborator

@msau42 msau42 commented Dec 1, 2020

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Updates csi-lib-utils to 0.9.0 to switch to klog v2

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Switching to klog v2

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 1, 2020
@msau42
Copy link
Collaborator Author

msau42 commented Dec 1, 2020

/assign @jsafrane @pohly

I don't know why, but klog v1 is still in the go.sum even though all the code and vendor/ are using klog v2 now. "go mod tidy" didn't help

@msau42
Update vendor to k8s 1.19 and csi-lib-utils to 0.9.0
1238d27 
Change-Id: I607c182c09a88a7daf1e4ffb67a28ab16d1f23ae
@pohly
Copy link
Contributor

pohly commented Dec 1, 2020

I don't know why, but klog v1 is still in the go.sum even though all the code and vendor/ are using klog v2 now.

I believe go.sum keeps some historic information. For example, k8s.io/klog v0.3.0 also has an entry. Not exactly sure though when that gets purged. Removing go.sum and re-creating it drops some entries, but not k8s.io/klog v0.3.0. I think we can ignore that.

What matters is that vendor/k8s.io/klog/ now only contains v2, so:
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2020
@k8s-ci-robot k8s-ci-robot merged commit 556a4c4 into kubernetes-csi:master Dec 1, 2020
robertpeteuil pushed a commit to robpco/csi-driver-nfs that referenced this pull request Dec 7, 2020
@k8s-ci-robot
Merge pull request kubernetes-csi#110 from pohly/kind-0.9-bazel-build…
0427289 
…-workaround

prow.sh: work around "kind build node-image" failure
pohly added a commit to pohly/csi-driver-nfs that referenced this pull request Jan 26, 2021
@pohly
Squashed 'release-tools/' changes from a0f195c..4aff857
4a6540f 
4aff857 Merge pull request kubernetes-csi#109 from pohly/alpha-test-defaults
0427289 Merge pull request kubernetes-csi#110 from pohly/kind-0.9-bazel-build-workaround
9a370ab prow.sh: work around "kind build node-image" failure
522361e prow.sh: only run alpha tests for latest Kubernetes release
22c0395 Merge pull request kubernetes-csi#108 from bnrjee/master
b5b447b Add go ldflags using LDFLAGS at the time of compilation
16f4afb Merge pull request kubernetes-csi#107 from pohly/kind-update
7bcee13 prow.sh: update to kind 0.9, support Kubernetes 1.19
df518fb prow.sh: usage of Bazel optional
c3afd42 Merge pull request kubernetes-csi#104 from xing-yang/snapshot
dde93b2 Update to snapshot-controller v3.0.0

git-subtree-dir: release-tools
git-subtree-split: 4aff857
dobsonj pushed a commit to dobsonj/csi-driver-nfs that referenced this pull request Oct 16, 2023
@openshift-merge-robot
Merge pull request kubernetes-csi#110 from shiftstack/merge-bot-master
a1f1089 
Merge https://github.com/kubernetes-csi/csi-driver-nfs:master into master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@pohly pohly

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@msau42 @k8s-ci-robot @pohly @jsafrane