Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable spelling and boilerplate checks in prow and local tests #134

Merged
merged 1 commit into from
Jan 16, 2021
Merged

Enable spelling and boilerplate checks in prow and local tests #134

merged 1 commit into from
Jan 16, 2021

Conversation

sachinkumarsingh092
Copy link
Contributor

@sachinkumarsingh092 sachinkumarsingh092 commented Jan 16, 2021 •
edited
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Enables spelling and boilerplate checks for prow tests and in hack/verify-all.sh for local checks.

Which issue(s) this PR fixes:
Fixes #128

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 16, 2021
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 16, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @sachinkumarsingh092. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 16, 2021
@sachinkumarsingh092
Copy link
Contributor Author

sachinkumarsingh092 commented Jan 16, 2021 •
edited
Loading

/cc @andyzhangx

@k8s-ci-robot
Copy link
Contributor

@sachinkumarsingh092: Those labels are not set on the issue: kind/failing, kind/test

In response to this:

/remove-kind failing test
/cc @andyzhangx

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sachinkumarsingh092
Copy link
Contributor Author

/remove-kind failing-test

@k8s-ci-robot k8s-ci-robot removed the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Jan 16, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 489828278

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.615%
Totals Coverage Status
Change from base Build 489125217: 0.0%
Covered Lines: 496
Relevant Lines: 623
💛 - Coveralls

@andyzhangx
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 16, 2021
andyzhangx
andyzhangx approved these changes Jan 16, 2021
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, sachinkumarsingh092

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit 7271a3c into kubernetes-csi:master Jan 16, 2021
@sachinkumarsingh092 sachinkumarsingh092 deleted the enable-spelling-boilerplate-prow-checks branch January 16, 2021 13:09
andyzhangx added a commit to andyzhangx/csi-driver-nfs that referenced this pull request Feb 22, 2021
@andyzhangx
Squashed 'release-tools/' changes from 7bc70e5..df76aba
49247cc 
df76aba Merge pull request kubernetes-csi#134 from andyzhangx/add-build-arg
e314a56 add build-arg ARCH for building multi-arch images, e.g. ARG ARCH FROM k8s.gcr.io/build-image/debian-base-${ARCH}:v2.1.3

git-subtree-dir: release-tools
git-subtree-split: df76aba
TerryHowe pushed a commit to TerryHowe/csi-driver-nfs that referenced this pull request Oct 17, 2024
@k8s-ci-robot
Merge pull request kubernetes-csi#134 from andyzhangx/add-build-arg
df76aba 
add build-arg ARCH
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@msau42 msau42 Awaiting requested review from msau42

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enable spelling and boilerplate check
4 participants
@sachinkumarsingh092 @k8s-ci-robot @coveralls @andyzhangx