Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provide more driver info in logs #149

Merged
merged 1 commit into from
Feb 5, 2021
Merged

provide more driver info in logs #149

merged 1 commit into from
Feb 5, 2021

Conversation

boddumanohar
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
The changes in this PR provides more information about the driver when the driver is started.

Which issue(s) this PR fixes:

Fixes #131

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 4, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @boddumanohar. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 4, 2021
andyzhangx
andyzhangx reviewed Feb 4, 2021
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

pkg/nfs/nfs.go Outdated
@@ -98,6 +98,13 @@ func NewNodeServer(n *Driver, mounter mount.Interface) *NodeServer {
}

func (n *Driver) Run(testMode bool) {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove empty line

pkg/nfs/version.go Outdated
@@ -0,0 +1,67 @@
/*
Copyright 2019 The Kubernetes Authors.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2021

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 4, 2021
@boddumanohar boddumanohar force-pushed the issues-131 branch 3 times, most recently from 16b9a05 to 7d9f362 Compare February 4, 2021 13:37
@coveralls
Copy link

coveralls commented Feb 4, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 539624894

  • 20 of 24 (83.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 79.601%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/nfs/nfs.go 4 6 66.67%
pkg/nfs/version.go 16 18 88.89%
Totals Coverage Status
Change from base Build 537776600: 0.1%
Covered Lines: 519
Relevant Lines: 652
💛 - Coveralls

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 4, 2021
@andyzhangx
Copy link
Member

andyzhangx commented Feb 5, 2021 •
edited
Loading

could you fill in the missing fields in this PR? thanks.

[pod/csi-nfs-controller-b565969cc-7fcmm/nfs] DRIVER INFORMATION:
[pod/csi-nfs-controller-b565969cc-7fcmm/nfs] -------------------
[pod/csi-nfs-controller-b565969cc-7fcmm/nfs] Build Date: N/A
[pod/csi-nfs-controller-b565969cc-7fcmm/nfs] Compiler: gc
[pod/csi-nfs-controller-b565969cc-7fcmm/nfs] Driver Name: nfs.csi.k8s.io
[pod/csi-nfs-controller-b565969cc-7fcmm/nfs] Driver Version: N/A
[pod/csi-nfs-controller-b565969cc-7fcmm/nfs] Git Commit: N/A
[pod/csi-nfs-controller-b565969cc-7fcmm/nfs] Go Version: go1.15.7
[pod/csi-nfs-controller-b565969cc-7fcmm/nfs] Platform: linux/amd64

you can check the logs from here: https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/kubernetes-csi_csi-driver-nfs/149/pull-csi-driver-nfs-e2e/1357325234801217536/build-log.txt

@boddumanohar boddumanohar force-pushed the issues-131 branch 2 times, most recently from 3ae43bd to 5cbf842 Compare February 5, 2021 06:52
@boddumanohar
Copy link
Contributor Author

@andyzhangx fixed

andyzhangx
andyzhangx approved these changes Feb 5, 2021
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, boddumanohar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2021
@k8s-ci-robot k8s-ci-robot merged commit 63c5d8a into kubernetes-csi:master Feb 5, 2021
@boddumanohar boddumanohar mentioned this pull request Jun 3, 2021
Closed
TerryHowe pushed a commit to TerryHowe/csi-driver-nfs that referenced this pull request Oct 17, 2024
@k8s-ci-robot
Merge pull request kubernetes-csi#149 from pohly/cluster-logs
f325590 
prow.sh: collect cluster logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@msau42 msau42 Awaiting requested review from msau42

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

provide more driver info in logs
4 participants
@boddumanohar @k8s-ci-robot @coveralls @andyzhangx