Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

images: use k8s-staging-test-infra/gcb-docker-gcloud #236

Closed
wants to merge 1 commit into from
Closed

images: use k8s-staging-test-infra/gcb-docker-gcloud #236

wants to merge 1 commit into from

Conversation

jimdaga
Copy link

@jimdaga jimdaga commented Oct 14, 2021

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Migrating gcb-docker-gcloud to to community-owned infrastructure

Which issue(s) this PR fixes:
Fixes # Migrate away from google.com gcp project k8s-testimages kubernetes/k8s.io#1523

Special notes for your reviewer:
Related:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 14, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @jimdaga!

It looks like this is your first PR to kubernetes-csi/csi-driver-nfs 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-driver-nfs has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @jimdaga. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 14, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jimdaga
To complete the pull request process, please assign msau42 after the PR has been reviewed.
You can assign the PR to them by writing /assign @msau42 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 14, 2021
@jimdaga jimdaga mentioned this pull request Oct 14, 2021
Open
77 tasks
andyzhangx
andyzhangx reviewed Oct 14, 2021
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you only need to make change to https://github.com/kubernetes-csi/csi-release-tools/blob/master/cloudbuild.yaml, not necessary to make changes in this repo.

@jimdaga
Copy link
Author

jimdaga commented Oct 14, 2021

you only need to make change to https://github.com/kubernetes-csi/csi-release-tools/blob/master/cloudbuild.yaml, not necessary to make changes in this repo.

Hey @andyzhangx thanks so much for the info.

I have a PR open for that file already (kubernetes-csi/csi-release-tools#175) So I'll go ahead and close all others - but keep the csi-release-tools pr open.

CC: @spiffxp

@jimdaga jimdaga closed this Oct 14, 2021
@jimdaga jimdaga reopened this Oct 14, 2021
@jimdaga jimdaga closed this Oct 14, 2021
@jimdaga jimdaga mentioned this pull request Oct 14, 2021
Merged
andyzhangx added a commit to andyzhangx/csi-driver-nfs that referenced this pull request Nov 27, 2023
@andyzhangx
Squashed 'release-tools/' changes from de2fba8..f8c8cc4
788c8ee 
f8c8cc4 Merge pull request kubernetes-csi#237 from msau42/prow
b36b5bf Merge pull request kubernetes-csi#240 from dannawang0221/upgrade-go-version
adfddcc Merge pull request kubernetes-csi#243 from pohly/git-subtree-pull-fix
c465088 pull-test.sh: avoid "git subtree pull" error
7b175a1 Update csi-test version to v5.2.0
987c90c Update go version to 1.21 to match k/k
2c625d4 Add script to generate patch release notes
f9d5b9c Merge pull request kubernetes-csi#236 from mowangdk/feature/bump_csi-driver-host-path_version
b01fd53 Bump csi-driver-host-path version up to v1.12.0
984feec Merge pull request kubernetes-csi#234 from siddhikhapare/csi-tools
1f7e605 fixed broken links of testgrid dashboard

git-subtree-dir: release-tools
git-subtree-split: f8c8cc4
TerryHowe pushed a commit to TerryHowe/csi-driver-nfs that referenced this pull request Oct 17, 2024
@k8s-ci-robot
Merge pull request kubernetes-csi#236 from mowangdk/feature/bump_csi-…
f9d5b9c 
…driver-host-path_version

Bump csi-driver-host-path version up to v1.12.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx left review comments

@ggriffiths ggriffiths Awaiting requested review from ggriffiths

@pohly pohly Awaiting requested review from pohly

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jimdaga @k8s-ci-robot @andyzhangx