Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add workingMountDir in chart config #263

Merged
merged 1 commit into from
Jan 5, 2022
Merged

feat: add workingMountDir in chart config #263

merged 1 commit into from
Jan 5, 2022

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind feature

What this PR does / why we need it:
feat: add workingMountDir in chart config

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

feat: add workingMountDir in chart config

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 3, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from jingxu97 and pohly January 3, 2022 13:02
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 3, 2022
@andyzhangx andyzhangx force-pushed the workingMountDir branch 6 times, most recently from 8c46412 to a028fed Compare January 4, 2022 03:51
@andyzhangx andyzhangx changed the title [WIP] feat: add workingMountDir in chart config feat: add workingMountDir in chart config Jan 4, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 4, 2022
@coveralls
Copy link

coveralls commented Jan 4, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1653874491

  • 27 of 32 (84.38%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 77.554%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/nfs/nodeserver.go 14 19 73.68%
Files with Coverage Reduction New Missed Lines %
pkg/nfs/controllerserver.go 1 72.65%
pkg/nfs/nodeserver.go 1 71.69%
Totals Coverage Status
Change from base Build 1653839856: 0.2%
Covered Lines: 539
Relevant Lines: 695
💛 - Coveralls

@andyzhangx
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 4, 2022
@andyzhangx
feat: add workingMountDir in chart config
405a69c 
fix tests

sudo

fix

test: fix test failure

fix test

install go 1.17

fix ut

fix test

fix test

fix test

fix tests

fix workingMountDir
@andyzhangx andyzhangx removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 5, 2022
@andyzhangx andyzhangx merged commit 5ae2584 into kubernetes-csi:master Jan 5, 2022
@neoaggelos neoaggelos mentioned this pull request Jan 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@pohly pohly Awaiting requested review from pohly

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andyzhangx @k8s-ci-robot @coveralls